Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve logs #866

Merged
merged 2 commits into from
Aug 12, 2024
Merged

chore: improve logs #866

merged 2 commits into from
Aug 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Aug 12, 2024 •
edited
Loading

Issue being fixed or feature implemented

Some logs are not clear enough or too verbose

What was done?

Improved logs:

  • removed overly verbose trace-level connection logs that don't add any value
  • added node_id to consensus logs, added peer to consensus proposal logs

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.2 milestone Aug 12, 2024
@lklimek lklimek marked this pull request as ready for review August 12, 2024 08:58
@lklimek lklimek enabled auto-merge (squash) August 12, 2024 08:58
shumkov
shumkov approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit f286feb into v1.2-dev Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov