Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): proposal not generated after waiting for last block time to pass #849

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jul 26, 2024

Issue being fixed or feature implemented

When initial genesis time is in the future, the proposal is never generated and node gets stuck.

What was done?

Fixed bug - round was not propagated in EnterProposeEvent.

How Has This Been Tested?

Run e2e tests
Added one unit test

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.2 milestone Jul 26, 2024
@lklimek lklimek changed the base branch from v1.1-dev to v1.2-dev July 31, 2024 08:35
@lklimek lklimek marked this pull request as ready for review July 31, 2024 08:37
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit bb00f7d into v1.2-dev Jul 31, 2024
15 checks passed
@lklimek lklimek deleted the fix/wait-for-genesis-time branch July 31, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants