Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abciclient)!: limit concurrent gRPC connections #775

Merged
merged 12 commits into from
Apr 22, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Apr 5, 2024

Issue being fixed or feature implemented

What was done?

  1. Implemented concurrency control for grpc - right now, it is possible to limit number of concurrent grpc connections per method name (like 'query' or 'checktx')
  2. Added new config section [abci] and moved relevant settings there
  3. Defined [abci] grpc-concurrency option - see toml.go for more details

How Has This Been Tested?

Implemented unit test.

Breaking Changes

Changes in config file:

  • created new [abci] section
  • abci moved to [abci] section and renamed to transport
  • proxy-app moved to [abci] section and renamed to address

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title feat(abciclient): limit concurrent gRPC connections feat(abciclient)!: limit concurrent gRPC connections Apr 9, 2024
@lklimek lklimek marked this pull request as ready for review April 9, 2024 12:46
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@shumkov shumkov merged commit 8383d57 into v0.14-dev Apr 22, 2024
16 checks passed
@shumkov shumkov deleted the feat/grpc-client-conn-limit branch April 22, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants