Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(abci)!: remove ExecTxResult.GasWanted #740

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Feb 15, 2024

Issue being fixed or feature implemented

ABCI protocol ExecTxResult.GasWanted is not used

What was done?

Removed ExecTxResult.GasWanted field and marked as reserved in .proto

How Has This Been Tested?

GHA

Breaking Changes

None, should be backwards-compatible, but requires the most recent version of rs-tenderdash-abci

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek merged commit 67084ca into v0.14-dev Feb 20, 2024
18 of 19 checks passed
@lklimek lklimek deleted the remove-exec-tx-result branch February 20, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants