This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
feat: show deprecation warning #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Sentinel has been deprecated, there's no need for it to execute any logic other than providing a deprecation notice.
UdjinM6
reviewed
Nov 30, 2023
UdjinM6
changed the title
UdjinM6
approved these changes
Dec 5, 2023
|
Why are the tests failing? Is there a trivial fix? |
|
we'll also need one final version bump and tag I guess |
thephez
changed the title
it probably expects clean output 🤷♂️ |
UdjinM6
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible final release (if necessary). Since Sentinel has been deprecated, there's no need for it to execute any logic other than providing a deprecation notice. I think something like this would do it. Tests blow up as expected.