Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expected service to be a string with ip address and port #1980

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 19, 2024

Issue being fixed or feature implemented

[12:20:11.610] ERROR (35): Invalid Argument: Expected service to be a string with ip address and port
Error
    at new NodeError (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/errors/index.js:23:40)
    at Object.checkArgument (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/util/preconditions.js:17:13)
    at SimplifiedMNListEntry.validate (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListEntry.js:204:7)
    at Function.fromObject (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListEntry.js:189:12)
    at new SimplifiedMNListEntry (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListEntry.js:72:36)
    at /platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListDiff.js:222:16
    at Array.map (<anonymous>)
    at Function.fromObject (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListDiff.js:221:44)
    at new SimplifiedMNListDiff (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListDiff.js:41:35)
    at MasternodeListSync.sync (/platform/packages/dapi/lib/MasternodeListSync.js:82:22)

What was done?

How Has This Been Tested?

Running a testnet node locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 19, 2024
ogabrielides
ogabrielides previously approved these changes Jul 19, 2024
@shumkov shumkov merged commit 2b4ccfa into v1.0-dev Jul 19, 2024
41 checks passed
@shumkov shumkov deleted the fix/expected-service-to-be-ip branch July 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants