Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: masternode hard fork signal transaction payload #301

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

thephez
Copy link

@thephez thephez commented Sep 11, 2024

Issue being fixed or feature implemented

Adds masternode hard fork signal special transaction payload based on the EHF DIP and docs.

What was done?

Used ChatGPT to create a PR modeled after #293.

Someone that knows what they're doing should thoroughly review this and test it (probably with dashcore-node on mainnet also to see if it will actually sync past the block containing the mnhftx).

How Has This Been Tested?

Includes tests that check against an actual mainnet mnhftx

Breaking Changes

None?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@thephez thephez marked this pull request as ready for review September 11, 2024 19:26
@thephez
Copy link
Author

thephez commented Sep 12, 2024

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 8b249a1 into dashpay:master Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants