Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown empty service IP #299

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: unknown empty service IP #299

merged 1 commit into from
Jul 19, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 19, 2024

Issue being fixed or feature implemented

[12:20:11.610] ERROR (35): Invalid Argument: Expected service to be a string with ip address and port
Error
    at new NodeError (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/errors/index.js:23:40)
    at Object.checkArgument (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/util/preconditions.js:17:13)
    at SimplifiedMNListEntry.validate (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListEntry.js:204:7)
    at Function.fromObject (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListEntry.js:189:12)
    at new SimplifiedMNListEntry (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListEntry.js:72:36)
    at /platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListDiff.js:222:16
    at Array.map (<anonymous>)
    at Function.fromObject (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListDiff.js:221:44)
    at new SimplifiedMNListDiff (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.2-db85f9aff6-61e640fd3d.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListDiff.js:41:35)
    at MasternodeListSync.sync (/platform/packages/dapi/lib/MasternodeListSync.js:82:22)

What was done?

  • Added shorthand IPv4 and IPv6

How Has This Been Tested?

Updated existing tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants