Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Set Content-Type application/vnd.pub.v2+json #38

Open
jonasfj opened this issue Apr 9, 2019 · 0 comments
Open

Set Content-Type application/vnd.pub.v2+json #38

jonasfj opened this issue Apr 9, 2019 · 0 comments
Labels

Comments

@jonasfj
Copy link
Contributor

jonasfj commented Apr 9, 2019

The client was originally designed to send Accept: application/vnd.pub.v2+json, to support multiple versions of the API.

I've recently documented this in:
https://github.com/dart-lang/pub/blob/master/doc/repository-spec-v2.md

We should probably start responding Content-Type: application/vnd.pub.v2+json to requests which carry Accept: application/vnd.pub.v2+json.

We might have to interpret no accept header or application/json accept header as to mean return Content-Type: application/json with the version 2 format. We could likely do some logging and figure out of this is necessary and then document it in the API docs.

But just returning Content-Type: application/vnd.pub.v2+json to requests with Accept: application/vnd.pub.v2+json is a good start. It means clients can start to check the Content-Type.

@jonasfj jonasfj added the bug label Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

1 participant