Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Correct wording (use future instead of present tense) #17464

Merged

Conversation

victoryforce
Copy link
Collaborator

We warn the user about the impossibility of undoing the panel reset. Therefore, we have to use the future tense (we are talking about the situation after the reset, this is the future). The use of the present tense here is not correct and may confuse the user.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't like too much "you" in the interface. When possible to avoid it would be nice, here maybe:

It will not be possible to restore the current panel layout and module selection.

What do you think?

@TurboGit TurboGit added this to the 5.0 milestone Sep 11, 2024
@TurboGit TurboGit added scope: translation / strings make darktable international scope: UI user interface and interactions labels Sep 11, 2024
@R08
Copy link

R08 commented Sep 11, 2024

In general I don't like too much "you" in the interface. When possible to avoid it would be nice, here maybe:

It will not be possible to restore the current panel layout and module selection.

What do you think?

Hi, I'm new to darktable and not familiar with this modal. Is it possible reduce and simplify the language further?

Restoring the current panel layout and module selection will not be possible.

Restoring panel layout and module selection will not be possible.

Panel layout and module selection cannot be restored.

Not sure if that last one should read "cannont" or "will not".

@victoryforce
Copy link
Collaborator Author

In general I don't like too much "you" in the interface. When possible to avoid it would be nice, here maybe:

It will not be possible to restore the current panel layout and module selection.

What do you think?

I completely understand your point and generally agree with it. The only question is where we can easily do without "you", and where impersonal rewording will be perceived by the user as somewhat artificial. I am still of the opinion that in dialogs where the user is informed/warned about something, it is better to keep "you" in the text, since this text is a direct address to the user. Impersonal text attracts the user's attention less. Do you agree?

@TurboGit
Copy link
Member

@victoryforce : No not really in agreement here, but that's a very personal feeling and so a very moot point. Let's not delay this further, we can adjust later if needed.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks!

@TurboGit TurboGit merged commit 99ddba1 into darktable-org:master Sep 12, 2024
6 checks passed
@victoryforce victoryforce deleted the future-tense-instead-of-present branch September 14, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: translation / strings make darktable international scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants