Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white balance presets for Panasonic Lumix DC-S9 #17459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sarunasb
Copy link
Contributor

Here are white balance presets for DC-S9.

@TurboGit TurboGit added this to the 5.0 milestone Sep 10, 2024
@TurboGit TurboGit added scope: camera support adding WB and raw support for new cameras depends: rawspeed cannot merge before rawspeed updated labels Sep 10, 2024
@kmilos
Copy link
Contributor

kmilos commented Sep 10, 2024

Hm, something not quite right w/ "Tungsten" (only 2 presets, and different ones at that, w/o tuning value)... Remove and keep "Incandescent" only?

Also, no Fluorescent and/or Flash?

@TurboGit TurboGit added controversial this raises concerns, don't move on the technical work before reaching a consensus labels Sep 11, 2024
@kmilos
Copy link
Contributor

kmilos commented Sep 11, 2024

Had a quick look at the manual, there's indeed only Daylight (Clear sky), Cloudy, Shade and Incandescent presets.

So I suggest to just remove the two Tungsten entries (probably coming from some legacy/redundant tag in the makernotes)...

Can we also please add this below the existing S5 to keep the sort order?

@sarunasb
Copy link
Contributor Author

sarunasb commented Sep 11, 2024

Thanks for checking. Indeed, S9 only offers four fixed named WB presets, at least in this initial firmware. Checking RW2s with exiftool the nomenclature is Daylight, Cloudy, Shade, Incandescent, with exiv2 interpreted — Daylight, Cloudy, Shade, Halogen, while camera menu offers Clear sky, Cloudy sky, Shade under a clear sky, Incandescent light.

‘Tungsten’ values removed in #17459.

@TurboGit TurboGit removed the controversial this raises concerns, don't move on the technical work before reaching a consensus label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends: rawspeed cannot merge before rawspeed updated scope: camera support adding WB and raw support for new cameras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants