Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inter script communication to Lua API #17300

Merged

Conversation

wpferguson
Copy link
Member

Added a new event, inter-script-communication

Bumped API to 9.4.0

Added a new utili module to the API for functions that don't fall into a specific category.

Added darktable.lua.message function for sending messages between scripts.

To test unzip the included test scripts zip file. Start darktable with the -d lua flag. Start both scripts. Assign a keyboard shortcut to send isc message. Press the shortcut key and observe the messages in the console output.

Fixes #17295.

Partial fix for #17296.

test_isc.zip

src/lua/configuration.h - bumped API to 9.4.0
src/lua/init.c          - added util module
src/lua/util.c          - added inter-script-communication event.
src/lua/util.h            Added darktable.util.message() function
                          to the API for sending messages between
                          scripts
@wpferguson wpferguson added the lua label Aug 9, 2024
@TurboGit TurboGit added this to the 5.0 milestone Aug 10, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug feature: new new features to add labels Aug 10, 2024
@wpferguson
Copy link
Member Author

Partial fix for darktable-org/lua-scripts#489

@wpferguson
Copy link
Member Author

@TurboGit can I get this merged please? There are multiple things waiting on this and I'm pretty much at a standstill.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comments. TIA.

src/lua/util.h Outdated Show resolved Hide resolved
src/lua/util.c Outdated Show resolved Hide resolved
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 826e29e into darktable-org:master Sep 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug feature: new new features to add lua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lua: Inter Script Communication
2 participants