[ColorCalib] update label to reflect whether color mapping is active #16810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
changed the title
ralfbrown
added a commit
to ralfbrown/dtdocs
that referenced
this pull request
Jun 5, 2024
…tive" text Documentation for darktable-org/darktable#16810.
elstoc
pushed a commit
to darktable-org/dtdocs
that referenced
this pull request
Jun 7, 2024
…tive" text Documentation for darktable-org/darktable#16810.
elstoc
added
documentation-complete
TurboGit
reviewed
Jul 29, 2024
|
"(active)" should be displayed whenever (and only when) the target is other than L 50 / chr 0.0, which is what is happening for me. The tag will display whether or not the module is active, because it will affect the results when the module does get turned on. |
When color-mapping chroma is 0, the hue slider has no effect, so say "active" only when either L != 50 or chroma != 0. Update the section label inside the value-changed callback for the items in the collapsible section so that we can immediately see the update instead of having to wait until an image is opened in darkroom view.
ralfbrown
force-pushed
the
colorcal_mapping
branch
from
460a0ce
to
3370094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to the repeated occurrences where someone unknowingly had color mapping activated and some recent suggestions on pixls.us. The label on the collapsible section for the color mapping controls now shows whether color mapping is active.
Update: figured out how to get immediate updates of the label text.