Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wb_presets: add Sony ILCE-7CM2 #15576

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

sams96
Copy link
Contributor

@sams96 sams96 commented Nov 5, 2023

Here's the Sony 7Cii white balance presets, acquired as described on the wiki page using the finetuned (properly) instructions. I didn't do the underwater preset because it is labelled as "Underwater Auto" on this camera, so I assume there's something extra going on there.

Also I got the error Warning: Unknown Sony Fluorescent WB Preset! a bunch of times from the script, but I'm not sure which preset was causing this, as they all seem to have made it into the output.

Copy link
Contributor

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

P.S. You still have the file that gave the "Unknown fluorescent" message?

@kmilos kmilos added the scope: camera support adding WB and raw support for new cameras label Nov 6, 2023
@kmilos
Copy link
Contributor

kmilos commented Nov 6, 2023

Going by the manual, it looks like -1, 0, 1, and 2 are the only options? Are we printing a spurious error on 0 maybe?

@sams96
Copy link
Contributor Author

sams96 commented Nov 6, 2023

@kmilos I do still have the files, but I tried again with the updated script and there's no errors any more, so it looks like you fixed it.

@kmilos
Copy link
Contributor

kmilos commented Nov 6, 2023

Thanks for checking!

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 4c25e93 into darktable-org:master Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: camera support adding WB and raw support for new cameras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants