snapshots: Remove snapshots for removed images. #15567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
added
bugfix
TurboGit
force-pushed
the
po/snapshot-delete-img
branch
from
0d37c7c
to
232088f
Compare
Avoid a crash, if an image is removed from the DB it is not anymore reacheable and cannot be used a snapshot. To do that we introduce a new signal DT_SIGNAL_IMAGE_REMOVED. In snapshots we connect to it and then we remove all snapshots created for the corresponding image. Fixes darktable-org#15565.
TurboGit
force-pushed
the
po/snapshot-delete-img
branch
from
232088f
to
e0ce7eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a crash, if an image is removed from the DB it is not anymore reacheable and cannot be used a snapshot. To do that we introduce a new signal DT_SIGNAL_IMAGE_REMOVED. In snapshots we connect to it and then we remove all snapshots created for the corresponding image.
Fixes #15565.