Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in slideshow #15555

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

dterrahe
Copy link
Member

@dterrahe dterrahe commented Nov 2, 2023

fixes #15554

Works for me with gcc and llvm. @TurboGit and @wpferguson please test.

@wpferguson
Copy link
Member

Works for me including the not displaying an actual image. I got 2 for 1. Thanks @dterrahe.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit added this to the 4.6 milestone Nov 2, 2023
@TurboGit TurboGit added bugfix pull request fixing a bug scope: codebase making darktable source code easier to manage labels Nov 2, 2023
@TurboGit
Copy link
Member

TurboGit commented Nov 2, 2023

A quite strange issue between GCC versions. We probably are in some undefined behavior. Anyway fixed.

@TurboGit TurboGit merged commit 55b8539 into darktable-org:master Nov 2, 2023
5 checks passed
@dterrahe dterrahe deleted the fix_slide_crash branch November 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug scope: codebase making darktable source code easier to manage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slideshow crashes due to recent change in dt_dev_image
3 participants