Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: cacorrect avoid colorshift #15550

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Bugfix: cacorrect avoid colorshift #15550

merged 1 commit into from
Nov 1, 2023

Conversation

jenshannoschwalm
Copy link
Collaborator

  1. correct algo making use of input data scaled to a range of 0->1
  2. fix colorshift correction

Fixes #15121

Improves results in #15505

@jenshannoschwalm
Fix cacorrect avoid colorshift
cd78bfd 
1. correct algo making use of input data scaled to a range of 0->1
2. fix colorshift correction
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels labels Nov 1, 2023
@jenshannoschwalm jenshannoschwalm added this to the 4.6 milestone Nov 1, 2023
@jenshannoschwalm
Copy link
Collaborator Author

Fixes a very old one :-)

TurboGit
TurboGit approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit cddf44c into darktable-org:master Nov 1, 2023
5 checks passed
@jenshannoschwalm jenshannoschwalm deleted the fix_avoid_colorshift branch November 2, 2023 04:28
@jenshannoschwalm
Copy link
Collaborator Author

@TurboGit a release note

Fixed 'avoid colorshift' in raw chromatic aberration

@TurboGit
Copy link
Member

TurboGit commented Nov 6, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

Green tint with the RAW Chromatic Aberrations module
2 participants
@jenshannoschwalm @TurboGit