Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Preserve input value_info for custom ops #327

Open
jchia opened this issue Apr 3, 2024 · 0 comments
Open

[Request] Preserve input value_info for custom ops #327

jchia opened this issue Apr 3, 2024 · 0 comments

Comments

@jchia
Copy link

jchia commented Apr 3, 2024

onnxsim is unable to do shape inference for custom op nodes that are not registered with onnxruntime and their downstream nodes. Making the shape inference work entails detailed C++ work for the custom op. (#284)

Can onnxsim be changed to allowing preserving value_info from the input graph, especially for custom op nodes for which it can't do shape inference? This is helpful especially for cases where input shape is static and the user can easily determine and provide the shape for the custom op outputs in the input model. This way, the user does not need understand how to write the arcane C++ code needed for custom ops.

@jchia jchia changed the title Preserve input value_info for custom ops [Request] Preserve input value_info for custom ops Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant