-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-sdk workflow quickstart #973
Conversation
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
@mikeee looks great so far. Any chance you could set the target of this PR against the |
Done ✅ |
Hey @mikeee, it looks like the test/check for Go is failing on this new quickstart. It's pretty basic with a not found error: Actual stdout:
ℹ️ Validating config and starting app "order-processor"
ℹ️ Started Dapr with app id "order-processor". HTTP Port: 45753. gRPC Port: 33929
ℹ️ Writing log files to directory : /home/runner/work/quickstarts/quickstarts/workflows/go/sdk/order-processor/.dapr/logs
== APP - order-processor == go: cannot find main module, but found .git/config in /home/runner/work/quickstarts/quickstarts
== APP - order-processor == to create a module there, run:
== APP - order-processor == cd ../../../.. && go mod init
The App process exited with error code: exit status 1
ℹ️ Received signal to stop Dapr and app processes. Shutting down Dapr and app processes. Could you please take a look? One thing I usually do is run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major blockers - just a couple suggestions.
Yep, I'm aware of the error. The issue is that there is no release candidate cut for the go-sdk. I have a module replace pointed at the branch with workflows merged and this quickstart is passing. I could test against |
Yes, if you can reference a go module built from go-sdk main branch that is fine. My only requirement is the quickstart can clone/restore/run on my machine, and on the GH action machine without additional steps. |
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Hi @mikeee - let's figure out how to get that Validate Go check working. It's still complaining about go.mod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to get Go Validate check passing
bump go validation workflow to 1.21 (cherry picked from commit ec1e515) Signed-off-by: mikeee <[email protected]>
cdb838d
to
5748410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds a go workflow quickstart.
Tested locally, wip until the workflow PR (dapr/go-sdk#487) is merged and an RC is cut.
Issue reference
Will close #965
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: