Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pub_sub javascript npm audit issues #1055

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

joebowbeer
Copy link
Contributor

Description

npm audit fix
and npm audit fix --force to upgrade axios

Issue reference

Please reference the issue this PR will close: #1054

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Joe Bowbeer <[email protected]>
@yaron2 yaron2 added this to the 1.14 milestone Jul 23, 2024
@joebowbeer
Copy link
Contributor Author

joebowbeer commented Jul 24, 2024

@yaron2 The error in javascript validation is in configuration/javascript/sdk (Not my changes)

== APP == Could not get config item, err:Error: DAPR_SIDECAR_COULD_NOT_BE_STARTED

I can repro this problem locally, too. #1047 (comment)

@yaron2 yaron2 merged commit 601a822 into dapr:master Jul 24, 2024
5 of 7 checks passed
@joebowbeer joebowbeer deleted the pub-sub-npm-audit-fixes branch July 24, 2024 10:17
paulyuk pushed a commit that referenced this pull request Jul 29, 2024
Signed-off-by: Joe Bowbeer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm audit fixes needed in pub_sub javascript quickstarts
2 participants