Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated version of nugets used in test project #1315

Conversation

m3nax
Copy link
Contributor

@m3nax m3nax commented Jun 26, 2024

Description

Consolidated version of coverlet.msbuild, coverlet.collector, xunit, xunit.runner.visualstudio, Microsoft.AspNetCore.Mvc.Testing, Moq to the same version in all projects.

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@m3nax m3nax closed this Jun 26, 2024
@m3nax m3nax reopened this Jun 26, 2024
…xunit.runner.visualstudio, Microsoft.AspNetCore.Mvc.Testing, Moq to the same version in all projects.

Signed-off-by: Manuel Menegazzo <[email protected]>
@m3nax m3nax force-pushed the consolidate-nuget-packages-version-used-in-test-projects branch from ef41bab to 76d2c3e Compare June 26, 2024 17:10
@m3nax m3nax marked this pull request as ready for review June 26, 2024 17:10
@m3nax m3nax requested review from a team as code owners June 26, 2024 17:10
@philliphoff philliphoff added this to the v1.15 milestone Jul 8, 2024
Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks pass and I don't see anything that stands out as blocking, so I think we're good to go.

@WhitWaldo WhitWaldo merged commit c47e650 into dapr:master Oct 8, 2024
10 checks passed
@WhitWaldo
Copy link
Contributor

@m3nax Thank you for the contribution!

@m3nax m3nax deleted the consolidate-nuget-packages-version-used-in-test-projects branch October 21, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants