Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider throwing a more specific exception than the generalized GrpcException for sidecar app errors #1370

Open
oising opened this issue Oct 17, 2024 · 1 comment

Comments

@oising
Copy link

oising commented Oct 17, 2024

Describe the feature

Currently (some? all?) sidecars application errors manifest as GrpcExceptions in apps. This should probably be wrapped as a general DaprException type to allow future more specific exceptions (e.g. DaprWorkflowException etc) to be thrown without breaking binary compatibility. Genuine Grpc protocol/comms errors should remain as GrpcException.

Release Note

RELEASE NOTE: ADD new dotnet DaprException as the base exception type to communicate exceptional conditions in the DAPR sidecar.

@oising oising added the kind/enhancement New feature or request label Oct 17, 2024
@WhitWaldo
Copy link
Contributor

Especially as we're looking to move Workflow to stable, I think it makes sense to start this work scoped just to Workflow in the client and revisit with other gRPC connections over time as able.

We've already got a common DaprException we can use for this, so no need to introduce another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants