Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow-quickstart.md regarding using Redis in production #4404

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

sclarke81
Copy link
Contributor

@sclarke81 sclarke81 commented Oct 28, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • [x ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [x ] Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Redis is used in the Workflows Quickstarts, but Redis isn't recommended for use in production (for Workflows). Added a note to the Quickstarts page to highlight this. I've raised this in response to discussions with Oli and Whit on Discord.

@sclarke81 sclarke81 requested review from a team as code owners October 28, 2024 10:54
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick typo fix - thank you!

…start.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Stephen Clarke <[email protected]>
@sclarke81
Copy link
Contributor Author

quick typo fix - thank you!

Good spot, thank you!

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 639362e into dapr:v1.14 Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants