Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow-patterns.md #4364

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Update workflow-patterns.md #4364

merged 4 commits into from
Oct 3, 2024

Conversation

bacek
Copy link
Contributor

@bacek bacek commented Sep 23, 2024

Make monitor code samples consistent between python/go and all other examples.

  • Python and Go are using seconds
  • Everything else is in minutes.

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Just make docs consistent

Make monitor code samples consistent between python/go and all other examples.

* Python and Go are using seconds
* Everything else is in minutes.

Signed-off-by: Vasily Chekalkin <[email protected]>
@bacek bacek requested review from a team as code owners September 23, 2024 01:55
Copy link

github-actions bot commented Oct 1, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Oct 1, 2024
@hhunter-ms hhunter-ms removed the stale label Oct 3, 2024
@msfussell msfussell added this to the 1.14 milestone Oct 3, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 7e20d6e into dapr:v1.14 Oct 3, 2024
7 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @bacek Thank you for your contribution!

Copy link

holopin-bot bot commented Oct 4, 2024

Congratulations @bacek, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm1ukqwt915240cl4iqx0xdea

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants