Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clarification that actors always need actorStateStore property set on state component #4362

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

There was a concern raised in Discord that the documentation wasn't as clear as it could be that a state store was required for actors regardless of whether any state was actually stored. This is a minor tweak to the documentation that reflects this requirement.

Issue reference

N/A

…of whether the actor actually stores any state.

Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo WhitWaldo requested review from a team as code owners September 19, 2024 17:38
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Sep 25, 2024
@github-actions github-actions bot closed this Oct 2, 2024
@yaron2 yaron2 reopened this Oct 2, 2024
@yaron2
Copy link
Member

yaron2 commented Oct 2, 2024

@hhunter-ms @msfussell

@github-actions github-actions bot removed the stale label Oct 3, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 09ffa77 into dapr:v1.14 Oct 3, 2024
7 checks passed
@WhitWaldo WhitWaldo deleted the actor-state-clarification branch October 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants