Reflecting valid value of 0-6, not 0-7 in jobs schedule #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <[email protected]>
|
Sorry about the previous PR notifications - my v1.14 branch was out of sync and I didn't notice it. |
|
/assign |
hhunter-ms
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
The Jobs documentation reflects some information pulled from the protos about what a valid "day of week" value is and states this accepts "0-7". This is not accurate - this PR mirrors my tweak to the proto itself and corrects this to reflect a valid value of "0-6" instead.
Issue reference
None - spotted while working on something else