Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listed missing HTTP and gRPC endpoint envvars used #4313

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

WhitWaldo
Copy link
Contributor

@WhitWaldo WhitWaldo commented Aug 14, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

I noticed that the published page listing the various environment variables was missing two of the values used today: DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT, so I've added them to the list.

Issue reference

N/A

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WhitWaldo - These are great missing additions. See my comments on examples to help developers.

daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/environment/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo
Copy link
Contributor Author

@msfussell For both examples, I'll come back and edit the language in the docs if/when another PR I created today is accepted and merged.

@msfussell msfussell merged commit 7492d5c into dapr:v1.13 Aug 15, 2024
4 checks passed
@WhitWaldo WhitWaldo deleted the missing_envvars branch August 19, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants