Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override head partial to ignore deprecated GA script from Docsy #4304

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

marcduiker
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The current Docsy version contains outdated html partials that try load Google Analytics files that no longer exists. This breaks Hugo when running the website locally.

Upgrading to the latest Docsy results in many more errors. This fix overrides the default head partial with a custom one without the GA scripts. Eventually, a complete update to the latest Docsy needs to be done to ensure quick upgrades.

Issue reference

#4281

@hhunter-ms hhunter-ms merged commit 316e8bb into dapr:v1.13 Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants