Add subscribe.v1alpha1 to the API allow list docs #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joni Collinge <[email protected]>
yaron2
approved these changes
Aug 5, 2024
hhunter-ms
requested changes
Aug 7, 2024
There was a problem hiding this comment.
@jjcollinge on line 117, could you try changing the link from:
https://github.com/dapr/dapr/blob/master/pkg/grpc/endpoints.go
to:
That might be holding up the PR build job.
Signed-off-by: Joni Collinge <[email protected]>
hhunter-ms
approved these changes
Aug 7, 2024
|
@holopin-bot @jjcollinge Thanks Joni! 😁 |
|
Congratulations @jjcollinge, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv9dyqs34840cidljrj6ff4 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API allow list docs to include the
susbcribe.v1alpha1gRPC API.The DCO check is failing as the base was originally wrong on the PR - the 1 commit in this PR does have the signature.