Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java pre-req on QuickStarts to JDK 17 #4251

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Jul 9, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Upgrading quickstarst pre requisites to Java SDK 17 from 11.

Issue reference

Closes #4222

@salaboy
Copy link
Contributor Author

salaboy commented Jul 9, 2024

@msfussell @artursouza please review and approve

Signed-off-by: salaboy <[email protected]>
@msfussell msfussell added waiting-on-code-pr The code PR needs to be merged before the docs are updated and removed waiting-on-code-pr The code PR needs to be merged before the docs are updated labels Jul 11, 2024
@hhunter-ms
Copy link
Collaborator

Docs are waiting on dapr/quickstarts#1042 to be merged

@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jul 11, 2024
@salaboy
Copy link
Contributor Author

salaboy commented Jul 12, 2024

@hhunter-ms thanks for the mention, I've reviewed the pending PR and approved.. I think that it is waiting for one more approval

@msfussell msfussell removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jul 20, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be merged given the quickstart PR is merged

@hhunter-ms hhunter-ms merged commit 1d226b4 into dapr:v1.13 Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Java required version in documentation for Quickstart
3 participants