Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add info about custom latency buckets #4236

Merged
merged 38 commits into from
Jul 10, 2024
Merged

add info about custom latency buckets #4236

merged 38 commits into from
Jul 10, 2024

Conversation

filintod
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Information about new customization of latency buckets.

Depends on dapr/dapr#7843

Issue reference

dapr/dapr#7641

@filintod filintod requested review from a team as code owners June 26, 2024 01:24
@filintod filintod changed the base branch from v1.14 to v1.13 June 26, 2024 12:25
@filintod filintod changed the base branch from v1.13 to v1.14 June 26, 2024 12:25
@filintod filintod force-pushed the filinto/custom-latency-buckets branch 3 times, most recently from c2b4960 to 79bfb32 Compare June 26, 2024 12:42
@filintod filintod changed the base branch from v1.14 to v1.13 June 26, 2024 12:43
@filintod filintod changed the base branch from v1.13 to v1.14 June 26, 2024 12:43
@filintod filintod force-pushed the filinto/custom-latency-buckets branch from 79bfb32 to 067d386 Compare June 26, 2024 12:49
@filintod filintod changed the base branch from v1.14 to v1.13 June 26, 2024 12:50
@filintod filintod force-pushed the filinto/custom-latency-buckets branch from c198983 to 6a68b4e Compare June 26, 2024 12:57
@filintod filintod changed the base branch from v1.13 to v1.14 June 26, 2024 12:57
nelson-parente and others added 11 commits June 26, 2024 08:11
@nelson-parente @filintod
doc: http metrics path normalization
84bc33c 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
doc: code review & path matching rename
0882e0f 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
doc: add configuration examples
bb2e4c2 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
update: update docs based on last proposal changes
69f50d6 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
feat: more updates based on the ingress/egress merge
db60dab 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
doc: code review comments
f125100 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
doc: code review comments
71e818f 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
feat: add excludeVerbs
e801370 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
feat: new line
41aa984 
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente @filintod
feat: add review meeting changes
b8eaf5e 
Signed-off-by: nelson.parente <[email protected]>
@filintod
v1.14 - cherry pick path normalization
749fff2 
Signed-off-by: Filinto Duran <[email protected]>
@filintod filintod force-pushed the filinto/custom-latency-buckets branch from 6a68b4e to 749fff2 Compare June 26, 2024 13:13
@filintod
Copy link
Contributor Author

@alicejgibbons

@filintod
add additional changes
118bbab 
Signed-off-by: Filinto Duran <[email protected]>
@filintod
add additional changes
6619664 
Signed-off-by: Filinto Duran <[email protected]>
@filintod
add additional changes
1c289bc 
Signed-off-by: Filinto Duran <[email protected]>
@filintod
format table
961a690 
Signed-off-by: Filinto Duran <[email protected]>
@filintod filintod requested a review from msfussell July 5, 2024 16:05
@msfussell
Copy link
Member

@filintod - Taking a look today

alicejgibbons
alicejgibbons approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished review, good to merge

hhunter-ms
hhunter-ms requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
filintod and others added 13 commits July 9, 2024 14:25
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
85bba8f 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
04adf9f 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
125cc16 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
3e35bc5 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
e8d856e 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
5997427 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
a63e422 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
833ef60 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
4215e02 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
a7ed609 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
800ad40 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/observability/metrics/metrics-o…
27d997f 
…verview.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod
Merge branch 'v1.14' into filinto/custom-latency-buckets
9be1451
msfussell
msfussell reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of simple changes.

daprdocs/content/en/operations/observability/metrics/metrics-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/observability/metrics/metrics-overview.md Show resolved Hide resolved
@msfussell msfussell merged commit 64a22cb into dapr:v1.14 Jul 10, 2024
4 checks passed
@jjcollinge jjcollinge mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejgibbons alicejgibbons alicejgibbons approved these changes

@hhunter-ms hhunter-ms hhunter-ms approved these changes

@msfussell msfussell Awaiting requested review from msfussell

Assignees

@filintod filintod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filintod @msfussell @alicejgibbons @hhunter-ms @nelson-parente