Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service invocation supports passing of query strings/fragments in URL #4217

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • [N/A] Commands include options for Linux, MacOS, and Windows within codetabs
  • [N/A] New file and folder names are globally unique
  • [N/A] Page references use shortcodes instead of markdown or URL links
  • [N/A] Images use HTML style and have alternative text
  • [N/A] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR seeks to supplement the service invocation documentation to clarify that a query string and fragment can be passed within the URL and Dapr will pass it through unchanged. I couldn't find this documentation otherwise documented anywhere except as a single test case in the .NET SDK

Issue reference

dapr/dotnet-sdk#1303

…e invocation request and it'll work without issue

Signed-off-by: Whit Waldo <[email protected]>
…rvice-invocation/howto-invoke-discover-services.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo
Copy link
Contributor Author

@hhunter-ms This PR has no dependency on the C# SDK PR I also created this morning as it's just sharing general guidance around the fact that the capability is there by default (where it's not presently called out).

…rvice-invocation/howto-invoke-discover-services.md

Signed-off-by: Mark Fussell <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit ae43d26 into dapr:v1.13 Jun 20, 2024
9 checks passed
@WhitWaldo WhitWaldo deleted the svc-invocation-querystring branch June 20, 2024 05:41
filintod pushed a commit to filintod/dapr_docs that referenced this pull request Jun 26, 2024
…dapr#4217)

* Clarified that a query string or fragment can be appended to a service invocation request and it'll work without issue

Signed-off-by: Whit Waldo <[email protected]>

* Update daprdocs/content/en/developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>

* Update daprdocs/content/en/developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md

Signed-off-by: Mark Fussell <[email protected]>

---------

Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants