-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service invocation supports passing of query strings/fragments in URL #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e invocation request and it'll work without issue Signed-off-by: Whit Waldo <[email protected]>
3 tasks
hhunter-ms
reviewed
Jun 19, 2024
...developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md
Outdated
Show resolved
Hide resolved
…rvice-invocation/howto-invoke-discover-services.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
@hhunter-ms This PR has no dependency on the C# SDK PR I also created this morning as it's just sharing general guidance around the fact that the capability is there by default (where it's not presently called out). |
msfussell
reviewed
Jun 19, 2024
...developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md
Show resolved
Hide resolved
…rvice-invocation/howto-invoke-discover-services.md Signed-off-by: Mark Fussell <[email protected]>
msfussell
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
filintod
pushed a commit
to filintod/dapr_docs
that referenced
this pull request
Jun 26, 2024
…dapr#4217) * Clarified that a query string or fragment can be appended to a service invocation request and it'll work without issue Signed-off-by: Whit Waldo <[email protected]> * Update daprdocs/content/en/developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]> * Update daprdocs/content/en/developing-applications/building-blocks/service-invocation/howto-invoke-discover-services.md Signed-off-by: Mark Fussell <[email protected]> --------- Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Mark Fussell <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This PR seeks to supplement the service invocation documentation to clarify that a query string and fragment can be passed within the URL and Dapr will pass it through unchanged. I couldn't find this documentation otherwise documented anywhere except as a single test case in the .NET SDK
Issue reference
dapr/dotnet-sdk#1303