Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actors] Add ttl and data to API reference #4188

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Conversation

hhunter-ms
Copy link
Collaborator

Description

Descriptions and examples for ttl and data are missing in the Actors API doc.

Need help with data example.

Issue reference

PR will close: #2926

Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms self-assigned this Jun 5, 2024
@hhunter-ms hhunter-ms requested review from a team as code owners June 5, 2024 15:31
@msfussell msfussell added this to the 1.14 milestone Jun 5, 2024
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms requested a review from JoshVanL June 5, 2024 20:49
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jun 11, 2024
@hhunter-ms hhunter-ms removed the stale label Jun 14, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshVanL - Comments and a question

daprdocs/content/en/reference/api/actors_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/actors_api.md Outdated Show resolved Hide resolved
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 751fb5e into dapr:v1.13 Jun 19, 2024
9 checks passed
filintod pushed a commit to filintod/dapr_docs that referenced this pull request Jun 26, 2024
* add ttl and data to actors api

Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/reference/api/actors_api.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/reference/api/actors_api.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/reference/api/actors_api.md

Signed-off-by: Mark Fussell <[email protected]>

* add explanation from josh

Signed-off-by: Hannah Hunter <[email protected]>

---------

Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Actors] Missing properties in Reminder and Timer API spec
3 participants