Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Azure ServiceBus Queue -name must match the Dapr pubsub topic #4174

Merged
merged 12 commits into from
Jul 15, 2024
Merged

The Azure ServiceBus Queue -name must match the Dapr pubsub topic #4174

merged 12 commits into from
Jul 15, 2024

Conversation

TomasEkeli
Copy link
Contributor

@TomasEkeli TomasEkeli commented May 30, 2024 •
edited
Loading

Description

Describe how to get past some stumbling-blocks when using Azure ServiceBus Queue as a pubsub component.

@TomasEkeli
Describe queue-name, policy and dead-letter queue aspects
8129bd1 
Describe how to get past stumbling-blocks I met when setting up a service-bus queue pubsub.

Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli
Update setup-azure-servicebus-queues.md
e912c50 
Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli
Update setup-azure-servicebus-queues.md
b924132 
Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli TomasEkeli marked this pull request as ready for review May 30, 2024 14:15
@TomasEkeli TomasEkeli requested review from a team as code owners May 30, 2024 14:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jun 5, 2024
@hhunter-ms hhunter-ms removed the stale label Jun 10, 2024
hhunter-ms
hhunter-ms requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

.../content/en/reference/components-reference/supported-pubsub/setup-azure-servicebus-queues.md Outdated Show resolved Hide resolved
.../content/en/reference/components-reference/supported-pubsub/setup-azure-servicebus-queues.md Outdated Show resolved Hide resolved
.../content/en/reference/components-reference/supported-pubsub/setup-azure-servicebus-queues.md Outdated Show resolved Hide resolved
.../content/en/reference/components-reference/supported-pubsub/setup-azure-servicebus-queues.md Outdated Show resolved Hide resolved
@msfussell
Copy link
Member

@TomasEkeli Ping on looking at these review comments. Thanks

@msfussell
Copy link
Member

@TomasEkeli - Ping again on this PR.

@msfussell
Copy link
Member

@TomasEkeli - Another ping again on this PR.

@TomasEkeli
Copy link
Contributor Author

sorry, been very busy. I have looked at these suggested changes, and they look excellent! thanks!

TomasEkeli and others added 5 commits June 30, 2024 20:28
@TomasEkeli @hhunter-ms
Update daprdocs/content/en/reference/components-reference/supported-p…
db646a0 
…ubsub/setup-azure-servicebus-queues.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli @hhunter-ms
Update daprdocs/content/en/reference/components-reference/supported-p…
1fed5a0 
…ubsub/setup-azure-servicebus-queues.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli @hhunter-ms
Update daprdocs/content/en/reference/components-reference/supported-p…
74a87a7 
…ubsub/setup-azure-servicebus-queues.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli @hhunter-ms
Update daprdocs/content/en/reference/components-reference/supported-p…
b758763 
…ubsub/setup-azure-servicebus-queues.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Tomas Ekeli <[email protected]>
@TomasEkeli
Merge branch 'v1.13' into patch-1
a38f756
@msfussell msfussell requested a review from yaron2 July 3, 2024 05:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jul 9, 2024
hhunter-ms
hhunter-ms approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - may still need a final review from @yaron2

@hhunter-ms hhunter-ms removed the stale label Jul 9, 2024
@github-actions GitHub Actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jul 15, 2024
@hhunter-ms hhunter-ms removed the stale label Jul 15, 2024
@hhunter-ms hhunter-ms merged commit 100388b into dapr:v1.13 Jul 15, 2024
7 checks passed
@TomasEkeli TomasEkeli deleted the patch-1 branch July 15, 2024 21:14
@yaron2 yaron2 added this to the 1.14 milestone Jul 31, 2024
@marcduiker
Copy link
Contributor

@holopin-bot @TomasEkeli Thank you!

@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @TomasEkeli, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8q79l91250cl7jhqfce3c

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell left review comments

@yaron2 yaron2 yaron2 approved these changes

@hhunter-ms hhunter-ms hhunter-ms approved these changes

Assignees

@TomasEkeli TomasEkeli

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
5 participants
@TomasEkeli @msfussell @marcduiker @yaron2 @hhunter-ms