Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that disabling kubernetes built in secret store can only be d… #4124

Merged
merged 1 commit into from
May 2, 2024
Merged

Clarify that disabling kubernetes built in secret store can only be d… #4124

merged 1 commit into from
May 2, 2024

Conversation

james-bartlett
Copy link
Contributor

@james-bartlett james-bartlett commented May 1, 2024

…one with an annotation, not by setting a helm argument

Clarify that disabling kubernetes built in secret store can only be done with an annotation, not by setting a helm argument

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Clarify that disabling kubernetes built in secret store can only be done with an annotation, not by setting a helm argument

Issue reference

…one with an annotation, not by setting a helm argument

Clarify that disabling kubernetes built in secret store can only be done with an annotation, not by setting a helm argument
Signed-off-by: James Bartlett <[email protected]>

Signed-off-by: james-bartlett <[email protected]>
@james-bartlett james-bartlett requested review from a team as code owners May 1, 2024 21:11
@msfussell msfussell merged commit 0bfa02b into dapr:v1.13 May 2, 2024
9 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @james-bartlett Thank you!

Copy link

holopin-bot bot commented May 7, 2024

Congratulations @james-bartlett, you just earned a badge! Here it is: https://holopin.io/claim/clvwfxscu134100fmmfsokxj35

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

salaboy pushed a commit to salaboy/docs that referenced this pull request Jun 21, 2024
…one with an annotation, not by setting a helm argument (dapr#4124)

Clarify that disabling kubernetes built in secret store can only be done with an annotation, not by setting a helm argument

Signed-off-by: james-bartlett <[email protected]>
Signed-off-by: salaboy <[email protected]>
@yaron2 yaron2 added this to the 1.14 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants