Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotReload: Subscription feature preview #4116

Merged
merged 7 commits into from
May 30, 2024

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Apr 18, 2024

Document Declarative Subscription hot reloading preview feature from dapr/dapr#7583

Closes #3217

Document Declarative Subscription hot reloading preview feature from
dapr/dapr#7583

Signed-off-by: joshvanl <[email protected]>
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 24, 2024
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review - thanks!

@msfussell msfussell removed the stale label Apr 25, 2024
Copy link

github-actions bot commented May 1, 2024

Stale PR, paging all reviewers

Copy link

github-actions bot commented May 8, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label May 8, 2024
@github-actions github-actions bot closed this May 15, 2024
@msfussell msfussell reopened this May 22, 2024
@msfussell
Copy link
Member

@JoshVanL - In addition to these changes, we need to make a overview feature entry after this heading https://docs.dapr.io/developing-applications/building-blocks/pubsub/pubsub-overview/#receiving-messages-with-topic-subscriptions for hotloading. Can you add a heading and paragraph here

@msfussell msfussell removed the stale label May 22, 2024
@JoshVanL
Copy link
Contributor Author

Thanks @msfussell @hhunter-ms! PTAL

Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label May 28, 2024
@msfussell msfussell removed the stale label May 28, 2024
…bsub/subscription-methods.md

Signed-off-by: Mark Fussell <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 709f1a4 into dapr:v1.14 May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants