Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update confusing examples for subscribePollInterval #4102

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

tlund101
Copy link
Contributor

@tlund101 tlund101 commented Apr 9, 2024

Most of the other options show an example identical to the default value. This was an exception and could prove confusing when reading the docs

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

Most of the other options show an example identical to the default value.  This was an exception and could prove confusing when reading the docs

Signed-off-by: Trevor Lund <[email protected]>
@tlund101 tlund101 requested review from a team as code owners April 9, 2024 19:36
Copy link

Stale PR, paging all reviewers

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hhunter-ms hhunter-ms merged commit b80bde3 into dapr:v1.13 Apr 25, 2024
9 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @tlund101

Copy link

holopin-bot bot commented May 7, 2024

Congratulations @tlund101, you just earned a badge! Here it is: https://holopin.io/claim/clvwfwzef144440fl9fui9zz4k

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@tlund101 tlund101 deleted the patch-2 branch May 7, 2024 15:07
@yaron2 yaron2 added this to the 1.14 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants