-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add (init) --dev documentation #4023
Conversation
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!Here are a few comments.
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-deploy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: mikeee <[email protected]>
Moved the paragraph down Signed-off-by: Mark Fussell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@msfussell The repositioning looks good to me 👍 |
This made sense to link it to the existing kubernetes init documentation and add a subsection with the
--dev
flag documented.Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
dapr init -k --dev
documentation in kubernetes operations--dev
example in the init cli reference.Issue reference
Please reference the issue this PR will close: #3781