Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry Token Validator spec #4017

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Sentry Token Validator spec #4017

merged 4 commits into from
Feb 9, 2024

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Feb 6, 2024

Adds documentation about sentry token validator spec, and control plane trust domain.

Closes #4001

@JoshVanL
Sentry Token Validator spec
fdd4cbf 
Adds documentation about sentry token validator spec, and control plane trust domain.

Signed-off-by: joshvanl <[email protected]>
@JoshVanL JoshVanL requested review from a team as code owners February 6, 2024 14:06
msfussell
msfussell reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshVanL Left some early comments. As always, if there is more you can add on the scenarios of when this would be useful, that helps tremendously. So add more of the why if possible.

daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Show resolved Hide resolved
@hhunter-ms hhunter-ms added this to the 1.13 milestone Feb 7, 2024
hhunter-ms
hhunter-ms requested changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small review on my part

daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/security/mtls.md Outdated Show resolved Hide resolved
@JoshVanL
Adds review comments
45b01ec 
Signed-off-by: joshvanl <[email protected]>
msfussell
msfussell approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit f33a9b7 into dapr:v1.13 Feb 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@hhunter-ms hhunter-ms hhunter-ms approved these changes

Assignees

@JoshVanL JoshVanL

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshVanL @msfussell @hhunter-ms