Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name resolution docs #4007

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Update name resolution docs #4007

merged 6 commits into from
Feb 6, 2024

Conversation

hhunter-ms
Copy link
Collaborator

Description

Related to #3991
Updates to name resolution docs

Issue reference

PR will close: #4005

@hhunter-ms hhunter-ms self-assigned this Feb 2, 2024
@hhunter-ms hhunter-ms requested review from a team as code owners February 2, 2024 21:06
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed this suggestion. https://github.com/dapr/docs/pull/4007/files#r1478870806 PTAL

@hhunter-ms
Copy link
Collaborator Author

I think you missed this suggestion. https://github.com/dapr/docs/pull/4007/files#r1478870806 PTAL

yep, I forgot to save it so it didn't make it in - just pushed!

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit e5c8721 into dapr:v1.13 Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants