Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying the behaviour of the ConsumerID field when configuring Kafka Pub/Sub #3935

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

KrylixZA
Copy link
Contributor

@KrylixZA KrylixZA commented Jan 3, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR details the behaviour of configuration the ConsumerID field in the Apache Kafka Pub/Sub component. It all revolves around this code which basically ignores the ConsumerID field of the ConsumerGroup field is defined. This PR simply updates the field description table to show that a combination of the consumer group and a random unique identifier is used when defining the consumerId if the consumer group field is set.

Issue reference

Closes #3697

@KrylixZA KrylixZA requested review from a team as code owners January 3, 2024 10:21
@yaron2 yaron2 merged commit 20494df into dapr:v1.12 Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify specification of ConsumerID for Kafka Pub/Sub Component
2 participants