Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Hot Reloading #3910

Merged

Conversation

JoshVanL
Copy link
Contributor

Adds documentation for the preview feature Component Hot Reloading

Part of dapr/dapr#1172

Adds documentation for Component Hot Reloading

Part of dapr/dapr#1172

Signed-off-by: joshvanl <[email protected]>
@JoshVanL JoshVanL requested review from a team as code owners December 19, 2023 16:42
@msfussell msfussell added this to the 1.13 milestone Dec 20, 2023
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 26, 2023
@github-actions github-actions bot closed this Jan 2, 2024
@hhunter-ms hhunter-ms reopened this Jan 2, 2024
@hhunter-ms hhunter-ms removed the stale label Jan 3, 2024
@hhunter-ms
Copy link
Collaborator

hhunter-ms commented Jan 4, 2024

@JoshVanL could you also update this doc for hot reloading as well? https://docs.dapr.io/operations/components/component-updates/ - Suggestion is to simply add to this document that if you enable the hotloading feature then you get reloading (and still describe the current behaviour if not set)

  • Add a section above 'Kubernetes' to briefly explain hotloading
  • Reword anywhere that implies components can't be updated automatically
  • Clarify if this applies to every component, including middleware?
  • Will hot reloading be a default when not in preview?

JoshVanL and others added 3 commits January 9, 2024 13:37
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Josh van Leeuwen <[email protected]>
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jan 9, 2024

Thanks @hhunter-ms @msfussell, I have added your suggestions.

Will hot reloading be a default when not in preview?

@hhunter-ms indeed, the plan to have this be the default and only option once HotReloading comes out of preview.

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

JoshVanL and others added 2 commits January 11, 2024 11:52
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Josh van Leeuwen <[email protected]>
@hhunter-ms hhunter-ms merged commit cc3d110 into dapr:v1.13 Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants