Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing arg value in multi-app-template.md #3856

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

stuartleeks
Copy link
Contributor

@stuartleeks stuartleeks commented Nov 3, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added a missing arg placeholder for dapr stop -f example

Issue reference

@stuartleeks stuartleeks requested review from a team as code owners November 3, 2023 13:39
@stuartleeks
Copy link
Contributor Author

I see that the validate-links check has failed, but I haven't made any links edits in this PR 😄

@hhunter-ms
Copy link
Collaborator

@stuartleeks hm I'm not sure why the link isn't working - it works for me. try bookending the 'broken' links with these:

< !-- IGNORE_LINKS -- >
< !-- END_IGNORE -- >

@stuartleeks
Copy link
Contributor Author

@hhunter-ms - it turns out that the broken link has a 301 redirect, so I've updated the links to the new URL

@hhunter-ms hhunter-ms merged commit 9d9e0e8 into dapr:v1.12 Nov 13, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants