Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dashboard helm release name conflict #3796

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Oct 7, 2023

Renames the helm release to dapr-dashboard from dapr

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Changes the documentation for deploying the dashboard using helm, notably only renaming the helm release name from dapr to dapr-dashboard to both prevent a release from being overwritten/updated.

Issue reference

Unreferenced issue - highlighted on discord.

@mikeee mikeee requested review from a team as code owners October 7, 2023 16:27
@msfussell
Copy link
Member

@mikeee - Is this the primary line you are addressing
helm install dapr-dashboard dapr/dapr-dashboard --namespace dapr-system
There is considerable formatting otherwise in this PR

@mikeee mikeee force-pushed the mikeee-fix-dashboard-conflict branch from f81e834 to 1d91cd2 Compare October 9, 2023 11:19
@mikeee
Copy link
Member Author

mikeee commented Oct 9, 2023

Removed any formatting changes other than the renamed argument

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution

@hhunter-ms hhunter-ms merged commit 643237a into dapr:v1.12 Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants