Adding docs for template based processing in k8s name resolution #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mukundan Sundararajan <[email protected]>
ItalyPaleAle
reviewed
Oct 5, 2023
Comment on lines
23
to
24
| "clusterDomain": "cluster.local" # Mutually exclusive with the template field | ||
| "template": "{{.ID}}-{{.Data.region}}.internal:{{.Port}}" # Mutually exclusive with the clusterDomain field |
There was a problem hiding this comment.
Suggested change
| "clusterDomain": "cluster.local" # Mutually exclusive with the template field | |
| "template": "{{.ID}}-{{.Data.region}}.internal:{{.Port}}" # Mutually exclusive with the clusterDomain field | |
| clusterDomain: "cluster.local" # Mutually exclusive with the template field | |
| template: "{{.ID}}-{{.Data.region}}.internal:{{.Port}}" # Mutually exclusive with the clusterDomain field |
ItalyPaleAle
reviewed
Oct 5, 2023
daprdocs/content/en/reference/components-reference/supported-name-resolution/nr-kubernetes.md
Outdated
Show resolved
Hide resolved
|
Thank you for this PR :) |
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
ItalyPaleAle
approved these changes
Oct 5, 2023
paulyuk
approved these changes
Oct 5, 2023
hhunter-ms
requested changes
Oct 5, 2023
daprdocs/content/en/reference/components-reference/supported-name-resolution/nr-kubernetes.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-name-resolution/nr-kubernetes.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Mukundan Sundararajan <[email protected]>
hhunter-ms
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Cluster Domain related to https://github.com/dapr/components-contrib/blob/master/nameresolution/kubernetes/kubernetes.go#L63
Template related to dapr/components-contrib#2883
Issue reference
Will close #3556