Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added errorIfNot2XX option to HTTP binding docs #3741

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

wimvc1
Copy link
Contributor

@wimvc1 wimvc1 commented Sep 18, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This documents the errorIfNot2XX option which has been part of the HTTP binding component since v1.10 or v1.11
See PR: dapr/components-contrib#2321

Issue reference

@wimvc1 wimvc1 requested review from a team as code owners September 18, 2023 06:10
@msfussell
Copy link
Member

@wimvc1 - Can you find the issue when this code was added?

@wimvc1
Copy link
Contributor Author

wimvc1 commented Sep 21, 2023

@wimvc1 - Can you find the issue when this code was added?

I think it is this one:
dapr/components-contrib#2321

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 5de4fdf into dapr:v1.11 Sep 25, 2023
7 checks passed
@yaron2 yaron2 added this to the 1.12 milestone Oct 11, 2023
artursouza pushed a commit to artursouza/docs that referenced this pull request Mar 1, 2024
* Added errorIfNot2XX option to HTTP binding docs

Signed-off-by: Wim Vande Casteele <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-bindings/http.md

Signed-off-by: Mark Fussell <[email protected]>

---------

Signed-off-by: Wim Vande Casteele <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
msfussell added a commit that referenced this pull request Mar 1, 2024
* Added errorIfNot2XX option to HTTP binding docs



* Update daprdocs/content/en/reference/components-reference/supported-bindings/http.md



---------

Signed-off-by: Wim Vande Casteele <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Co-authored-by: wimvc1 <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants