-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added errorIfNot2XX option to HTTP binding docs #3741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wim Vande Casteele <[email protected]>
@wimvc1 - Can you find the issue when this code was added? |
I think it is this one: |
msfussell
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
daprdocs/content/en/reference/components-reference/supported-bindings/http.md
Outdated
Show resolved
Hide resolved
…indings/http.md Signed-off-by: Mark Fussell <[email protected]>
artursouza
pushed a commit
to artursouza/docs
that referenced
this pull request
Mar 1, 2024
* Added errorIfNot2XX option to HTTP binding docs Signed-off-by: Wim Vande Casteele <[email protected]> * Update daprdocs/content/en/reference/components-reference/supported-bindings/http.md Signed-off-by: Mark Fussell <[email protected]> --------- Signed-off-by: Wim Vande Casteele <[email protected]> Signed-off-by: Mark Fussell <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Artur Souza <[email protected]>
7 tasks
msfussell
added a commit
that referenced
this pull request
Mar 1, 2024
* Added errorIfNot2XX option to HTTP binding docs * Update daprdocs/content/en/reference/components-reference/supported-bindings/http.md --------- Signed-off-by: Wim Vande Casteele <[email protected]> Signed-off-by: Mark Fussell <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: wimvc1 <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This documents the
errorIfNot2XX
option which has been part of the HTTP binding component since v1.10 or v1.11See PR: dapr/components-contrib#2321
Issue reference