add clientName and heartBeat metadata for pubsub rabbitmq #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangchao <[email protected]>
hhunter-ms
requested changes
Sep 12, 2023
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
|
@Taction please look at the comment and resolve conflicts |
Signed-off-by: Hannah Hunter <[email protected]>
|
resolved conflicts |
…ubsub/setup-rabbitmq.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Taction <[email protected]>
|
@hhunter-ms Thanks for your review and for resolving conflicts! |
|
@Taction - This PR is in the v1.11 docs, but the code is in v1.12. Can you move this PR to target the v1.12 docs? Thanks |
|
@msfussell Thanks for pointing out that. I opened another pr #3740 to target the v1.12 doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Add missing content.
Issue reference
Please reference the issue this PR will close: #3710