Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate NATS Streaming PubSub component #3042

Closed
2 tasks done
ItalyPaleAle opened this issue Aug 4, 2023 · 3 comments · Fixed by #3043
Closed
2 tasks done

Deprecate NATS Streaming PubSub component #3042

ItalyPaleAle opened this issue Aug 4, 2023 · 3 comments · Fixed by #3043
Assignees
Labels
kind/bug Something isn't working P1 size/XS 2 days of work
Milestone

Comments

@ItalyPaleAle
Copy link
Contributor

ItalyPaleAle commented Aug 4, 2023

The NATS Streaming PubSub component is currently in beta.

NATS Streaming is officially deprecated. The server does not receive security fixes as of June 2023: https://github.com/nats-io/nats-streaming-server Maintainer instead recommend using NATS JetStream, which Dapr already supports.

Aside from the server being deprecated, the client library we depend on is deprecated as well. This means it does not receive security fixes.

We should deprecate the component in Dapr 1.12, and decide on which version it will be officially removed from.

@ItalyPaleAle ItalyPaleAle added the kind/bug Something isn't working label Aug 4, 2023
@ItalyPaleAle ItalyPaleAle self-assigned this Aug 4, 2023
@ItalyPaleAle ItalyPaleAle added this to the v1.12 milestone Aug 4, 2023
@berndverst
Copy link
Member

Let's add a deprecation warning in 1.12 and remove in 1.14. cc @yaron2 @artursouza

@berndverst berndverst added P1 size/XS 2 days of work labels Aug 4, 2023
@ItalyPaleAle
Copy link
Contributor Author

Thoughts on accelerating to 1.13 since it's beta? I would like to not have a dependency in this repo that is archived. 1.14 is probably not coming for another 7-8 months so that's a long time.

@artursouza
Copy link
Member

I am fine either way. One release seems reasonable and more than what we promise for non-stable components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working P1 size/XS 2 days of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants