Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16678 ci: fetch in gen_commit_pragmas.py #15493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daltonbohning
Copy link
Contributor

Run git fetch before git merge-base in case the repo is outdated.

Test-tag: pr,vm

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Run git fetch before git merge-base in case the repo is outdated.

Test-tag: pr,vm

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Ticket title is 'gen_commit_pragmas.py appears to use an outdated repo'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16678

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15493/1/testReport/

@daltonbohning daltonbohning marked this pull request as ready for review November 12, 2024 19:24
@daltonbohning
Copy link
Contributor Author

phender
phender previously approved these changes Nov 12, 2024
Skip-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
Copy link
Contributor Author

daltonbohning commented Nov 13, 2024

I'm not sure if this is helping anything or not. @jolivier23 tested on a separate PR and it still does not work
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15492/5/pipeline/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants