fixed #13129 - apply --std with --clang / fixed usage of Standards::stdValue
#6742
+192
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
"fun" fact: I found part of this in a 2.5 year old local changelist... |
firewave
force-pushed
the
stdvalue
branch
3 times, most recently
from
b9240dc
to
2b1e751
Compare
firewave
force-pushed
the
stdvalue
branch
5 times, most recently
from
4149fc7
to
e8590cd
Compare
firewave
changed the title
Standards::stdValue--std with --clang / fixed usage of Standards::stdValue
|
CC @ludviggunne please also take a look at what you made me do 😉 |
|
Sorry! |
I was asking for a review not pleasantries. 😁 |
|
Looks good to me. |
|
Thanks! |
danmar
reviewed
Sep 28, 2024
danmar
reviewed
Sep 29, 2024
|
|
||
| bool setC(std::string str) { | ||
| stdValue = str; |
There was a problem hiding this comment.
I just wonder if setC and setCPP are needed.
If only setStd is called from outside we could implement all the logic in that directly or make setC and setCPP private? I feel maybe the code would be a bit simpler but on the other hand testability is important too.
There was a problem hiding this comment.
That should be detected by the CI then. Maybe there is a conflict. Will take a look later. And more changes are coming and will integrate that cleanup if possible.
danmar
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.